Skip to content

Conversation

zeke
Copy link
Contributor

@zeke zeke commented May 9, 2017

This PR moves the responsibility of linting the electron.d.ts file into the module itself, so electron/electron will have fewer moving typescript parts.

The CLI now programmatically runs tslint on the generated output. If there are no errors, the file is written and the process exits with 0. If there are errors, they are printed and the process exits with 1.

cc @MarshallOfSound @kevinsawicki

@zeke zeke merged commit ffa3939 into master May 9, 2017
@zeke zeke deleted the lint-on-create branch May 9, 2017 22:37
@zeke
Copy link
Contributor Author

zeke commented May 9, 2017

~/electron/electron-typescript-definitions master ⇡ 20s
❯ np minor --yolo
 ✔ Prerequisite check
 ✔ Git
 ✔ Bumping version using Yarn
 ✔ Publishing package
 ✔ Pushing tags

 electron-typescript-definitions 1.2.0 published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant