Skip to content

Conversation

MarshallOfSound
Copy link
Member

This will stop issues happening again with generated types

/cc @zeke

Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes solid sense!

@MarshallOfSound MarshallOfSound merged commit f0e8658 into master May 11, 2017
@MarshallOfSound MarshallOfSound deleted the check-output-on-gen branch May 11, 2017 01:17
@zeke
Copy link
Contributor

zeke commented May 11, 2017

@MarshallOfSound published this as 1.2.1

@zeke
Copy link
Contributor

zeke commented May 11, 2017

I'm seeing this now on Electron master:

$ electron-docs-linter docs --outfile=electron-api.json --version=1.7.0
$ electron-typescript-definitions --in=electron-api.json --out=electron.d.ts

error TS6053: File '/Users/z/electron/electron/node_modules/electron-typescript-definitions/test-smoke/electron/test/index.ts' not found.

error TS6053: File '/Users/z/electron/electron/node_modules/electron-typescript-definitions/test-smoke/electron/test/main.ts' not found.
error TS6053: File '/Users/z/electron/electron/node_modules/electron-typescript-definitions/test-smoke/electron/test/renderer.ts' not found.

Maybe a gitignore or npmignore issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants