Skip to content

Wrap numeric keys in quotes #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2017
Merged

Wrap numeric keys in quotes #61

merged 4 commits into from
May 31, 2017

Conversation

zeke
Copy link
Contributor

@zeke zeke commented May 31, 2017

Fixes #60

This PR wraps key names like 2d_canvs in quotes to prevent TS compiler errors. It also updates the CLI to produce more readable error output.

@zeke zeke requested a review from kevinsawicki May 31, 2017 19:00
kevinsawicki
kevinsawicki approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@kevinsawicki kevinsawicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeke zeke merged commit ed576ae into master May 31, 2017
@zeke zeke deleted the better-debugging-output branch May 31, 2017 19:05
@zeke
Copy link
Contributor Author

zeke commented May 31, 2017 

~/git/electron/electron-typescript-definitions master
❯ np patch 
 ✔ Prerequisite check
 ✔ Git
 ✔ Cleanup
 ✔ Installing dependencies using Yarn
 ✔ Running tests
 ✔ Bumping version using Yarn
 ✔ Publishing package
 ✔ Pushing tags

 electron-typescript-definitions 1.2.7 published 🎉

@zeke zeke mentioned this pull request May 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kevinsawicki kevinsawicki kevinsawicki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeke @kevinsawicki