This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Fix a small bug on default_spec #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cls.thrift_spec = thrift_spec | ||
|
|
||
| if "default_spec" is not None: |
There was a problem hiding this comment.
I dont understand why that I change x is not None to x cannot pass the travis-ci @maralla
|
I have changed the code @maralla |
|
May you please rebase the three commits to one commit? |
…rameter and modify some code which is not pythonic.
|
I've already done. @lxyu |
|
👍 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the misusing of
default_specwith a string format instead of a parameterModify the code which is not very pythonic.
gen_initfunction in thrift.py,default_specis a parameter not a string.is not Noneis not a good way of using python.