-
Notifications
You must be signed in to change notification settings - Fork 235
Add Google Tink dependency, replacing androidx.security.crypto
#4405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Tink dependency, replacing androidx.security.crypto
#4405
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4405 +/- ##
===========================================
- Coverage 80.10% 80.05% -0.05%
===========================================
Files 2063 2065 +2
Lines 55180 55212 +32
Branches 6765 6765
===========================================
Hits 44201 44201
- Misses 8664 8696 +32
Partials 2315 2315 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
) { | ||
private val androidKeysetManager by lazy { | ||
val keysetManagerBuilder = AndroidKeysetManager.Builder() | ||
.withKeyTemplate(KeyTemplates.get("AES256_GCM_HKDF_4KB")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you extract those constants?
I don't really like to have to use all those androidx constants by default :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not great, but using our own constants means adding a migration system for somethings that's not supposed to change ever (unless we wanted to change something like the encryption scheme 😓 ).
|
Content
Motivation and context
The library is being deprecated and was causing some conflicts related to it using an outdated Tink version. Maybe @BillCarsonFr should also take a quick look?
Tests
Start the app with a logged in account, if it works fine the replacement works.
Tested devices
Checklist