-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quick and dirty /join command #3288
Conversation
ElementX/Sources/Services/Authentication/AuthenticationService.swift
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger Swift against 9fdf1f2 |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3288 +/- ##
===========================================
- Coverage 77.37% 77.34% -0.03%
===========================================
Files 735 735
Lines 59446 59475 +29
===========================================
+ Hits 45995 46001 +6
- Misses 13451 13474 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e131c19
to
8cac60c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
cf8132b
to
9fdf1f2
Compare
Quality Gate passedIssues Measures |
In order to avoid getting crucified by the matrix community for shipping a matrix client which can't join rooms by alias (somewhat like shipping a web browser without a url bar), here's a quick go at adding a
/join
slash command as an easter-egg for powerusers.I've probably done it wrong, but:
openURL
- but it has to use the one inside the SwiftUI environment given that's where the local app routing happens (otherwise it goes and opens it in an external app). So I pull an openURL handler in a closure through in the state bindings from the TimelineView to the TimelineViewModel. I assume there may be a fancier way to get SwiftUI to handle the openURL, but this seems to work fine even if it's a bit ugly. (How come AppMediator has a useless open() method which doesn't use the App's openURL impl?)Pull Request Checklist