-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the SDK and use media filename
and caption
internally.
#3375
Conversation
Generated by 🚫 Danger Swift against 0abf19d |
❌ 3 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Doesn't render captions yet (other than in fallback places).
cf523f8
to
0abf19d
Compare
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, ship it!
This PR adopts matrix-org/matrix-rust-sdk#4081 so that we correctly compute a media file's filename/caption. It doesn't render captions in the timeline yet (it does in replies and the room list but essentially we did this anyway).
Fixes #3278