Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SDK and use media filename and caption internally. #3375

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 7, 2024

This PR adopts matrix-org/matrix-rust-sdk#4081 so that we correctly compute a media file's filename/caption. It doesn't render captions in the timeline yet (it does in replies and the room list but essentially we did this anyway).

Fixes #3278

@pixlwave pixlwave requested a review from a team as a code owner October 7, 2024 16:23
@pixlwave pixlwave requested review from stefanceriu and removed request for a team October 7, 2024 16:23
Copy link

github-actions bot commented Oct 7, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0abf19d

@pixlwave pixlwave added the pr-misc for other changes label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
840 3 837 0
View the full list of 3 ❄️ flaky tests
PreviewTests test_identityConfirmationScreen()

Flake rate in main: 21.74% (Passed 36 times, Failed 10 times)

Stack Traces | 2.48s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_identityConfirmationScreen-iPhone-16-pseudo.1.png"
@+
"file:.../tmp/PreviewTests/test_identityConfirmationScreen-iPhone-16-pseudo.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.94415283 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_serverSelection()

Flake rate in main: 16.67% (Passed 20 times, Failed 4 times)

Stack Traces | 6.36s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"
@+
"file:.../tmp/PreviewTests/test_serverSelection-iPhone-16-en-GB.3.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.91864014 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 26.02% (Passed 91 times, Failed 32 times)

Stack Traces | 14s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Doesn't render captions yet (other than in fallback places).
Copy link

sonarcloud bot commented Oct 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.2% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, ship it!

@pixlwave pixlwave merged commit 6e51969 into develop Oct 8, 2024
6 of 7 checks passed
@pixlwave pixlwave deleted the doug/filenames branch October 8, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images with long alt text can't be viewed fullscreen
2 participants