Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Slack integration and Slack Alert message builder to make them editable easily #1490

Merged
merged 4 commits into from
Apr 14, 2024
Merged

Refactor Slack integration and Slack Alert message builder to make them editable easily #1490

merged 4 commits into from
Apr 14, 2024

Conversation

IDoneShaveIt
Copy link
Collaborator

  • Templates now return pydantic schema
  • Converting template to Slack message is now happening as part of _get_alert_template

@linear Linear
Copy link

linear bot commented Apr 14, 2024

ELE-2936 Make Slack message editable easily

@github-actions GitHub Actions
Copy link
Contributor

👋 @IDoneShaveIt
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

noaKurman
noaKurman approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@noaKurman noaKurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IDoneShaveIt IDoneShaveIt merged commit 831fe48 into master Apr 14, 2024
3 checks passed
@IDoneShaveIt IDoneShaveIt deleted the ele-2936-make-slack-message-editable-easily branch April 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noaKurman noaKurman noaKurman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IDoneShaveIt @noaKurman