-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fuzzy-finder-like way of opening documents within the active project #134
Comments
I would be interesting in tackling this one. Couple questions though: Would this be better as a plugin, or as part of the core code? Atom tries to use ripGrep under the hood when possible. I've set up vim to use fzf and ag for the searching. Should we have options for which util to use under the hood? |
If Code is anything like Files then there are problems assigning a short-cut to a plugin. Maybe better as part of the code under the Scratch.FolderManager namespace? |
@ssedrick Providing an option to choose a searching util is probably not something that needs to be exposed to the user—not according to the HIG at least. It's both simpler and more user-friendly to pick one that integrates well, and use that. |
Out of curiosity, is anyone still looking at this issue? If not, I would be willing to take a look into this file search functionality! |
I haven't been able to get anywhere with this, so if you want to take it, @CodeforEvolution, please do. |
Cool! In that case, I believe there will be some necessary UI adjustments as a part of this ticket. Otherwise, here is what I had in mind:
Feel free to give feedback on this idea! (I'll wait on the coding until I have gotten a sufficient amount, just to be safe!) |
+1 to using CtrlShiftF for the shortcut (unless it conflicts with something else), simply because that's what VS Code users are used to. |
IMO Ctrl+P would be more logical as this is the shortcut for fuzzy-searching file names in VSCode, Atom, and Google Chrome / Firefox dev tools; Ctrl+Shift+F makes more sense for finding text across files. |
Note: I've removed the mentions of a bounty since we have moved away from Bountysource and refunded all bounties as of June. |
It's been a while since there's been activity in the existing pull request for this issue. Would it be okay if a new pull request (created by someone else) was created that includes the changes from #1159? |
@colinkiama Yes, as the original person did not respond to my last message I think it is OK to take this over if you wish. |
From Launchpad bug 1547620:
The text was updated successfully, but these errors were encountered: