feat:sticky navbar #2973
Open
feat:sticky navbar #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisgoddard
requested changes
Apr 21, 2022
| @@ -245,6 +244,11 @@ nav { | |||
| min-width: 100%; | |||
| overflow-x: auto; | |||
| white-space: nowrap; | |||
| position: sticky; | |||
| position: -webkit-sticky; | |||
There was a problem hiding this comment.
Pretty sure these two should be the other way around.
| @@ -779,7 +784,7 @@ select, | |||
| .button { | |||
| appearance: none; | |||
| background-color: transparent; | |||
| background-image: linear-gradient(to bottom, transparent, transparent 50%, rgba(0, 0, 0, 0.04)); | |||
| background-image: linear-gradient(to bottom, transparent, transparent 50%,rgba(0, 0, 0, 0.04)); | |||
There was a problem hiding this comment.
Not sure why this space is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2967
Changes Summary
Proposal for a sticky navbar per the issue mentioned above.
Currently, on mobile devices, the navbar has CSS property
overflow-x: auto;, which makes you scroll through the nav options. Is this something that should stay as is, or would a mobile menu (dialog) be ideal?This pull request is ready for review.