Work-around for win32-input-mode mouse sequences and SGR extended mouse report #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 15, 2024 23:02
…#2072 (Work in Progress)
* cleanup code * disable logs * correct parsing for win32-input mode * documented workflow of this fix as well as standard parsing procedure
This was referenced Mar 19, 2024
* complete refactoring of mouse input process * added support for mouse tracking * All three modifiers are now suported in mouse events: Shift, Alt, Ctrl * Unwrapping win32-input mode also supported for SGR
Dazzar56
changed the title
This was referenced Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2072
Here is complite fix for double encoded mouse sequences in win32-input-mode under WSL.
Due to bug in events encoding in windows ConPTY, mouse input not only encoded in X10 mouse sequences but characters in it also encoded again as win32-input-mode sequences. I patch up this by adding separate buffer for for accumulate unpacked chracters and then parsing it sepparatly.
In addition, I wrote some annotations to describe the process..
All tested under windows 11 WSL Ubuntu 22.04. Seems works just fine.