Skip to content

chore: deps management #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2024
Merged

chore: deps management #20

merged 3 commits into from
Jul 25, 2024

Conversation

JaeAeich
Copy link
Contributor

@JaeAeich JaeAeich commented Jul 8, 2024

Add pyproject and makefile just for an easier dx.

Summary by Sourcery

This pull request adds a Makefile to streamline common development tasks such as creating virtual environments, installing dependencies, and generating documentation. Additionally, a README.md file has been added to provide instructions on using the Makefile.

  • Documentation:
    • Added a README.md file with instructions on using the Makefile for development tasks.
  • Chores:
    • Introduced a Makefile to simplify environment management and documentation generation tasks.

Copy link
Contributor

sourcery-ai bot commented Jul 8, 2024

Reviewer's Guide by Sourcery

This pull request adds a Makefile to streamline common development tasks such as creating a virtual environment, installing dependencies, and generating documentation. The README.md file has been updated to include instructions on how to use these new Makefile commands.

File-Level Changes

Files Changes
Makefile
README.md
Introduced a Makefile to simplify development tasks and updated the README.md to document the new commands.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JaeAeich - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 3 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@JaeAeich JaeAeich requested a review from uniqueg July 8, 2024 08:32
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the Sourcery comments - otherwise I think this is good.

@JaeAeich JaeAeich requested a review from uniqueg July 24, 2024 07:35
@JaeAeich
Copy link
Contributor Author

please approve and merge :)

@JaeAeich JaeAeich merged commit 97239d3 into main Jul 25, 2024
@JaeAeich JaeAeich deleted the dx branch July 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants