-
Notifications
You must be signed in to change notification settings - Fork 2
chore: deps management #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds a Makefile to streamline common development tasks such as creating a virtual environment, installing dependencies, and generating documentation. The README.md file has been updated to include instructions on how to use these new Makefile commands. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the Sourcery comments - otherwise I think this is good.
please approve and merge :) |
Add
pyproject
andmakefile
just for an easier dx.Summary by Sourcery
This pull request adds a Makefile to streamline common development tasks such as creating virtual environments, installing dependencies, and generating documentation. Additionally, a README.md file has been added to provide instructions on using the Makefile.