Skip to content

Conversation

kafaichoi
Copy link
Contributor

@kafaichoi kafaichoi commented May 31, 2025

closes #14

@kafaichoi kafaichoi force-pushed the kafai/fix-complex-with-bug branch 4 times, most recently from d0b9a86 to 31b5d17 Compare May 31, 2025 13:53
@kafaichoi kafaichoi force-pushed the kafai/fix-complex-with-bug branch from efc065c to 0ed4cad Compare May 31, 2025 14:22
Copy link
Member

@Schultzer Schultzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good to me, I’m currently on vacation and away from my computer.

I’m not sure why the action did not run for your PR.

@kafaichoi
Copy link
Contributor Author

kafaichoi commented Jun 1, 2025

Thank you! This looks good to me, I’m currently on vacation and away from my computer.

I’m not sure why the action did not run for your PR.

yea. I believe it's the default behavior of not running CI for forked branch. We need to specify trigger it in pull_request in .github/workflow/ci.yml (I did run the test locally and it passed)

on:
  - push
  - pull_request

@Schultzer Schultzer merged commit 3119462 into elixir-dbvisor:main Jun 1, 2025
@Schultzer
Copy link
Member

Schultzer commented Jun 1, 2025

Thank you! This looks good to me, I’m currently on vacation and away from my computer.
I’m not sure why the action did not run for your PR.

yea. I believe it's the default behavior of not running CI for forked branch. We need to specify trigger it in pull_request in .github/workflow/ci.yml (I did run the test locally and it passed)

on:
  - push
  - pull_request

The conformance tests broke https://github.com/elixir-dbvisor/sql/actions/runs/15372760900/job/43254022513

If you’re up for it, please push a PR which adds the changes to our actions and fixes the parser for the conformance tests.

You can generate conformance test: sql.gen.test sqltest/standards/2016

Keep in mind that it requires you to clone elliotchance/sqltest

@kafaichoi
Copy link
Contributor Author

Thank you! This looks good to me, I’m currently on vacation and away from my computer.
I’m not sure why the action did not run for your PR.

yea. I believe it's the default behavior of not running CI for forked branch. We need to specify trigger it in pull_request in .github/workflow/ci.yml (I did run the test locally and it passed)

on:
  - push
  - pull_request

The conformance tests broke https://github.com/elixir-dbvisor/sql/actions/runs/15372760900/job/43254022513

If you’re up for it, please push a PR which adds the changes to our actions and fixes the parser for the conformance tests.

You can generate conformance test: sql.gen.test sqltest/standards/2016

Keep in mind that it requires you to clone elliotchance/sqltest

Sure. I will try to fix it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect generated sql when using with
2 participants