Skip to content

Allow Ecto.UUID to dump values that are already 16 byte binaries #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow Ecto.UUID to dump values that are already 16 byte binaries #1585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/ecto/uuid.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,15 @@ defmodule Ecto.UUID do
{:ok, binary}
end
end


@doc """
Returns value unchanged if it is already a 16 byte binary
"""
def dump(value) when byte_size(value) == 16 do
{:ok, value}
end

def dump(_), do: :error

@compile {:inline, d: 1}
Expand Down
3 changes: 2 additions & 1 deletion test/ecto/uuid_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ defmodule Ecto.UUIDTest do

test "dump" do
assert Ecto.UUID.dump(@test_uuid) == {:ok, @test_uuid_binary}
assert Ecto.UUID.dump(@test_uuid_binary) == :error
assert Ecto.UUID.dump(@test_uuid_binary) == {:ok, @test_uuid_binary}
assert Ecto.UUID.dump("") == :error
end

test "generate" do
Expand Down