Use proper range increment for values list #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rate limit =(. i will re-run later |
|
This syntax will require a more recent Elixir version, but we can use https://www.erlang.org/docs/23/man/lists#seq-3 meanwhile. |
|
thank you :) |
|
@josevalim is it alright if I merge this one? |
josevalim
approved these changes
Oct 11, 2024
dkuku
pushed a commit
to dkuku/ecto_sql
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-reading the SQL generated in the error report for empty values list I noticed it produces 2 empty values:
So just adjusting the range increment to be right. We might no have to care about it but just in case we make more changes to empty list behaviour in the future I want to avoid getting bit by this.