Skip to content

Only log 'forward' and 'backward' for 'change/0' #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Only log 'forward' and 'backward' for 'change/0' #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/ecto/migration/runner.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ defmodule Ecto.Migration.Runner do
{:ok, runner} = DynamicSupervisor.start_child(Ecto.MigratorSupervisor, {__MODULE__, args})
metadata(runner, opts)

log(level, "== Running #{version} #{inspect(module)}.#{operation}/0 #{direction}")
direction_msg = if operation == :change, do: " #{direction}", else: nil

log(level, "== Running #{version} #{inspect(module)}.#{operation}/0#{direction_msg}")
{time, _} = :timer.tc(fn -> perform_operation(repo, module, operation) end)
log(level, "== Migrated #{version} in #{inspect(div(time, 100_000) / 10)}s")
after
Expand Down
4 changes: 2 additions & 2 deletions test/ecto/migrator_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ defmodule Ecto.MigratorTest do
:ok = up(TestRepo, 12, UpDownMigration)
end)

assert output =~ "== Running 12 Ecto.MigratorTest.UpDownMigration.up/0 forward"
assert output =~ "== Running 12 Ecto.MigratorTest.UpDownMigration.up/0"
assert output =~ "alter table posts"
assert output =~ ~r"== Migrated 12 in \d.\ds"

Expand All @@ -336,7 +336,7 @@ defmodule Ecto.MigratorTest do
:ok = down(TestRepo, 12, UpDownMigration)
end)

assert output =~ "== Running 12 Ecto.MigratorTest.UpDownMigration.down/0 forward"
assert output =~ "== Running 12 Ecto.MigratorTest.UpDownMigration.down/0"
assert output =~ "execute \"foo\""
assert output =~ ~r"== Migrated 12 in \d.\ds"
end
Expand Down
Loading