Use Elixirs new formatter?

[sascha-wolf]

Elixir will introduce an opinionated formatter in version 1.6. I think it would be great to include it in this package.

Would that be possible?

[anildigital]

@zeeker you can use this package https://github.com/anildigital/mix-format.el

[anildigital]

Can we start integrating work done here https://github.com/anildigital/mix-format.el in official Elixir mode? Any taker?

[Trevoke]

I'm not aware of any modes or tools built-in to emacs that require external tools, other than the ones emacs has a reasonable expectation of finding, such as grep.

I like the idea of one format for all (as long as it's my format), but I like even more the idea of elixir-mode being part of vanilla emacs.

Since there's no obligation for anyone using emacs to actually have elixir installed on their machine, let alone elixir 1.6, let alone have mix in their $PATH, I'd say if we're going to integrate this at all, it should be behind a flag so everyone can benefit from the built-in indentation.

[anildigital]

@Trevoke Absolutely agree. But let's also find out what was original motivation and goal behind mix format when @josevalim brought it in Elixir. If José meant that this should be turned on by default, I think we have to make it on by default. Else it should be turned off by default. Thanks.

[josevalim]

In my opinion the best workflow is to run the formatter whenever you want the whole file or whatever is on the buffer to be formatted. If someone is using an earlier Elixir version, then you can abort by saying mix format is not available for that version.

[Trevoke]

Okay, so:

1. An interactive function is available to run the formatter on the content of a buffer (maybe current buffer by default)
2. Failure situations:
   a. Version of mix available does not have the command
   b. mix is not available
   c. given buffer does not exist (can probably let it fail)
   d. given buffer is read-only (can probably let it fail)
3. Config:
   a. path to Elixir 1.6's mix so we can run the command even if we are in a pre-1.6 project ?

What else?

[Trevoke]

@anildigital While Jose's original motivation and goal are important, we have to accept the reality of "people will run emacs in a variety of settings, and we have to be emacs-centric when we devise solutions for emacs".

[jasongoodwin]

Ya there are things I don't like about the elixir 1.6 formatting tbh. Eg with puts do on the last clause.
But it would be nice if most of the indentation suggestions followed the elixir 1.6 standard in elixir mode.

[anildigital]

Can we integrate https://github.com/anildigital/mix-format.el in official Elixir Mode for emacs now?

[josevalim]

@anildigital yes, please do send a PR. Remember it needs to be opt-in since not everyone will be running on Elixir v1.6. Probably under some key binding by default.

[anildigital]

I have raised PR #406 Looks like no activity in ths project /cc @tonini @mattdeboard @antifuchs

[Trevoke]

Now that #406 is merged in, this is done.