`mix cmd` change

[LostKobrakai]

Elixir and Erlang/OTP versions

Erlang/OTP 28 [erts-16.1] [source] [64-bit] [smp:14:14] [ds:14:14:10] [async-threads:1] [jit]

Elixir 1.19.0-rc.2 (957f84b) (compiled with Erlang/OTP 28)

Operating system

Mac OS X

Current behavior

Mix.Task.run("cmd", ~w(--cd=assets FORCE_COLOR=1 npx vitest run) ++ args)

this triggers the following error.

** (ErlangError) Erlang error: :enoent
    (elixir 1.19.0-rc.2) lib/system.ex:1140: System.cmd("\"FORCE_COLOR=1", ["npx", "vitest", "run\""], [stderr_to_stdout: true, into: %Mix.Shell{callback: #Function<0.96010653/1 in Mix.Shell.IO.cmd/2>}, cd: "assets"])
    (mix 1.19.0-rc.2) lib/mix/shell.ex:163: Mix.Shell.cmd/3
    (mix 1.19.0-rc.2) lib/mix/tasks/cmd.ex:80: Mix.Tasks.Cmd.run/1
    (mix 1.19.0-rc.2) lib/mix/task.ex:499: anonymous fn/3 in Mix.Task.run_task/5
    (mix 1.19.0-rc.2) lib/mix/task.ex:586: Mix.Task.run_alias/6
    (mix 1.19.0-rc.2) lib/mix/cli.ex:131: Mix.CLI.run_task/2
    /Users/benni/.local/share/mise/installs/elixir/1.19.0-rc.2-otp-28/bin/mix:7: (file)

f978b57#diff-f82d94d7a2b150cfc758710b8087595e52d0c45b307da7e35c2c8bbfe8e426f1R76

This change causes the called code to use System.cmd instead of System.shell, which looks like the cause of the change in behaviour, see https://github.com/elixir-lang/elixir/blob/main/lib/mix/lib/mix/shell.ex#L162-L165.

Expected behavior

This used to work.

[LostKobrakai]

#14506 (comment) Sounds like there was already work started fixing this.

[LostKobrakai]

Hmm, using sh didn't work, but using env did:

Mix.Task.run("cmd", ~w(--cd=assets env FORCE_COLOR=1 npx vitest run) ++ args)