Deprecate defdelegate with lists and append_first #4199

Closed
josevalim opened this Issue Jan 14, 2016 · 4 comments

Projects

None yet

3 participants

@josevalim
Member

I believe those features do not map well to Elixir semantics anymore. You want each defdelegate to be on its own line so you can control module attributes like @doc and append_first can be confusing when using defaults (which are more useful than append_first).

/cc @tuvistavie @lexmag

@lexmag
Member
lexmag commented Jan 14, 2016

Strongly 👍 for defdelegate with lists deprecation, not sure about append_first though.

Edit: 👍 for append_first as well.

@tuvistavie
Contributor

I totally agree for defdelegate with lists.
I think append_first is useful, but I agree it adds too much complexity compared to the benefits, especially when used with optional parameters.

@josevalim
Member

@tuvistavie can you please tackle this as well once your PR lands? :)

@tuvistavie
Contributor

Sure!

@tuvistavie tuvistavie added a commit to tuvistavie/elixir that referenced this issue Jan 15, 2016
@tuvistavie tuvistavie Add deprecation for defdelegate list arguments and append_first optio…
…n. Close #4199.
1196d2b
@tuvistavie tuvistavie added a commit to tuvistavie/elixir that referenced this issue Jan 15, 2016
@tuvistavie tuvistavie Add deprecation for defdelegate list arguments and append_first optio…
…n. Close #4199.
f0d525c
@tuvistavie tuvistavie added a commit to tuvistavie/elixir that referenced this issue Jan 15, 2016
@tuvistavie tuvistavie Add deprecation for defdelegate list arguments and append_first optio…
…n. Close #4199.
f65de99
@josevalim josevalim closed this in 6f89c41 Jan 15, 2016
@iancanderson iancanderson added a commit to iancanderson/apartmentex that referenced this issue Jul 25, 2016
@iancanderson iancanderson Remove call to deprecated version of defdelegate b5877c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment