1.9.0 mix release doesn't work well with included_application

[sunboshan]

Environment

• Elixir & Erlang/OTP versions (elixir --version): otp 22.0.4/elixir 1.9.0
• Operating system: darwin

Current behavior

mix.exs

  defp deps do
    [
      {:geolix, "~> 0.18.0"},
    ]
  end

➜ mix deps.get
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  geolix 0.18.0
  mmdb2_decoder 1.0.1
  poolboy 1.5.2
* Getting geolix (Hex package)
* Getting mmdb2_decoder (Hex package)
* Getting poolboy (Hex package)

tmp/ex/a via 💧 v1.9.0 took 2s
➜ MIX_ENV=prod mix release
===> Compiling poolboy
==> mmdb2_decoder
Compiling 5 files (.ex)
Generated mmdb2_decoder app
==> geolix
Compiling 38 files (.ex)
Generated geolix app
==> a
Compiling 1 file (.ex)
Generated a app
* assembling a-0.1.0 on MIX_ENV=prod
* skipping runtime configuration (config/releases.exs not found)
** (Mix) Undefined applications: [mmdb2_decoder]

Here's the mix.exs from geolix dep

  def application do
    [
      applications: [:logger, :poolboy],
      included_applications: [:mmdb2_decoder],
      mod: {Geolix, []}
    ]
  end

The workaround here is simply move included_applications to applications like this in the library

  def application do
    [
      applications: [:logger, :poolboy, :mmdb2_decoder],
      included_applications: [],
      mod: {Geolix, []}
    ]
  end

I'm not sure if this is a mix bug, or it should be fixed on the library part. But for now, the mix release is not working well with libraries that using included_application.

[josevalim]

Fixed and backporrted. Can you plaese give the v1.9 branchc a try? Thanks.

[xdays]

It's still there.

[3:45] ➜  naboo git:(elixir-1.9) mix -v
Erlang/OTP 20 [erts-9.0.1] [source] [64-bit] [smp:2:2] [ds:2:2:10] [async-threads:10] [hipe] [kernel-poll:false]

Mix 1.9.1 (compiled with Erlang/OTP 20)
[3:45] ➜  naboo git:(elixir-1.9) elixir -v
Erlang/OTP 20 [erts-9.0.1] [source] [64-bit] [smp:2:2] [ds:2:2:10] [async-threads:10] [hipe] [kernel-poll:false]

Elixir 1.9.1 (compiled with Erlang/OTP 20)
[3:45] ➜  naboo git:(elixir-1.9) MIX_ENV=prod mix release
** (Mix) :combine is listed both as a regular application and as an included application
[3:46] ➜  naboo git:(elixir-1.9) grep -r ':combine' .
./deps/gen_smtp/src/mimemail.erl:	smtp_util:combine_rfc822_addresses(lists:zip(NewNames, Emails));
./deps/timex/mix.exs:    [applications: [:logger, :tzdata, :gettext, :combine],
./deps/timex/mix.exs:     {:combine, "~> 0.10"},
./deps/remote_ip/mix.exs:     included_applications: [:combine, :inet_cidr]]
./deps/remote_ip/mix.exs:    [{:combine, "~> 0.10"},

[alexandremcosta]

@josevalim This is a repository with the replicated error: https://github.com/alexandremcosta/elixir_issues_9163

It's just a plain mix new application with timex and remote_ip deps.
Run MIX_ENV=prod mix release and you will see it.

[josevalim]

@alexandremcosta your error is intentional. You cannot have an application both as a regular application or an included application:

** (Mix) :combine is listed both as a regular application and as an included application

Is there any reason why :combine is an included application in the first place?