Skip to content

generate error for unused "do" expression in EEx #10566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2020
Merged

generate error for unused "do" expression in EEx #10566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fabd533
generate error for unused "do" expression in EEx
superhawk610 Dec 13, 2020
e9dc255
update error message, remove extra test
superhawk610 Dec 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/eex/lib/eex/compiler.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@ defmodule EEx.Compiler do
scope,
state
) do
if mark != '=' do
message =
"the contents of this expression won't be output unless the EEx block starts with \"<%=\""

:elixir_errors.erl_warn(start_line, state.file, message)
end

{contents, line, rest} = look_ahead_middle(rest, start_line, chars)

{contents, rest} =
Expand Down
9 changes: 9 additions & 0 deletions lib/eex/test/eex/smart_engine_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ defmodule EEx.SmartEngineTest do
assert_received :found
end

test "error with unused \"do\" block without \"<%=\" modifier" do
stderr =
ExUnit.CaptureIO.capture_io(:stderr, fn ->
assert_eval("", "<% if true do %>I'm invisible!<% end %>", assigns: %{})
end)

assert stderr =~ "the contents of this expression won't be output"
end

defp assert_eval(expected, actual, binding \\ []) do
result = EEx.eval_string(actual, binding, file: __ENV__.file, engine: EEx.SmartEngine)
assert result == expected
Expand Down