Skip to content

Implement a break-trigger for incomplete expressions in IEx. #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2013

Conversation

alco
Copy link
Member

@alco alco commented May 19, 2013

No description provided.

@alco
Copy link
Member Author

alco commented May 19, 2013

Should I also follow this up with a mention in the Getting Started guide and/or IEx.Helpers.h/0?

@josevalim
Copy link
Member

👍 I would also mention it in h/0. :)

@alco
Copy link
Member Author

alco commented May 20, 2013

@josevalim Check it out.

@josevalim
Copy link
Member

Thanks, this is excellent! Quick question: is there a particular reason to
make it resemble a shebang? Could this lead to confusion?

José Valim
www.plataformatec.com.br
Founder and Lead Developer
*

@alco
Copy link
Member Author

alco commented May 20, 2013

I opted for additional character after # to make it even more unlikely to
be encountered in comments. It could be any other character rarely used in
the prefix position.

If you think I'm being to cautious here, I don't mind making it just
#break.

On Mon, May 20, 2013 at 2:45 PM, José Valim notifications@github.comwrote:

Thanks, this is excellent! Quick question: is there a particular reason to
make it resemble a shebang? Could this lead to confusion?

José Valim
www.plataformatec.com.br
Founder and Lead Developer
*


Reply to this email directly or view it on GitHubhttps://github.com//pull/1096#issuecomment-18143389
.

Best regards
Alexei Sholik

@meh
Copy link
Contributor

meh commented May 20, 2013

I like #!break, I think it makes sense to avoid as much as possible false positives.

@josevalim
Copy link
Member

Got it. The shebang resemblance is not good though :S what do you think
of: #iex:break ?

I would also like some kind of iex prefix/suffix to make it very clear it
is an iex only thing.

José Valim
www.plataformatec.com.br
Founder and Lead Developer
*

@alco
Copy link
Member Author

alco commented May 20, 2013

#iex:break seems good. I'll update the PR in a minute.

On Mon, May 20, 2013 at 3:01 PM, José Valim notifications@github.comwrote:

Got it. The shebang resemblance is not good though :S what do you think
of: #iex:break ?

I would also like some kind of iex prefix/suffix to make it very clear it
is an iex only thing.

José Valim
www.plataformatec.com.br
Founder and Lead Developer
*

Reply to this email directly or view it on GitHubhttps://github.com//pull/1096#issuecomment-18143907
.

Best regards
Alexei Sholik

@alco
Copy link
Member Author

alco commented May 20, 2013

Changed #!break to #iex:break and rebased on master.

On Mon, May 20, 2013 at 3:07 PM, Alexei Sholik alcosholik@gmail.com wrote:

#iex:break seems good. I'll update the PR in a minute.

On Mon, May 20, 2013 at 3:01 PM, José Valim notifications@github.comwrote:

Got it. The shebang resemblance is not good though :S what do you think
of: #iex:break ?

I would also like some kind of iex prefix/suffix to make it very clear it
is an iex only thing.

José Valim
www.plataformatec.com.br
Founder and Lead Developer
*

Reply to this email directly or view it on GitHubhttps://github.com//pull/1096#issuecomment-18143907
.

Best regards
Alexei Sholik

Best regards
Alexei Sholik

josevalim pushed a commit that referenced this pull request May 20, 2013
Implement a break-trigger for incomplete expressions in IEx.
@josevalim josevalim merged commit 08e6afe into elixir-lang:master May 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants