Add support for .iex files #1100
Conversation
|
|
||
| @doc false | ||
| def print_exception(exception) do | ||
| print_stacktrace System.stacktrace, fn -> |
There was a problem hiding this comment.
You need to explicitly pass the stacktrace as argument from the catch block. By calling another function, you may modify the stacktrace (it happens when the module is first accessed at runtime for example).
We could change it though. I.e. ignore new bindings by default, but provide some kind of |
|
|
||
| # Locates and loads an .iex file from one of predefined locations | ||
| defp load_dot_iex(config) do | ||
| path = Enum.find [".iex", "~/.iex"], File.regular?(&1) |
There was a problem hiding this comment.
File.regular? doesn't expand "~/.iex", does it?
|
Added some comments, everything else is perfect. So feel free to merge whenever you are ready! |
|
@josevalim Thanks. What about the |
| @@ -201,4 +238,28 @@ defmodule IEx do | |||
| defp run_after_spawn do | |||
| lc fun inlist Enum.reverse(after_spawn), do: fun.() | |||
| end | |||
|
|
|||
| # Locates and loads an .iex file from one of predefined locations | |||
There was a problem hiding this comment.
One last feedback, can we move this to IEx.Server? Then all code evaluation will be in IEx.Server and there will be no need for IEx.Util too.
|
I am ok with supporting the |
|
Another note, maybe we should call it |
| Sample contents of a local .iex file: | ||
|
|
||
| # source another .iex file, ~/.iex in this case | ||
| Code.require_file ".iex", "~" |
There was a problem hiding this comment.
It just came to my mind that a variable set inside the required file won't propagate to the iex binding. Maybe we should support a import_file() inside IEx.Helpers after all as you originally proposed that people would be able to call any time.
|
On the other hand, since we can override variables in Elixir, I don't really see the pressing concern for adding |
|
@josevalim I'm ready to rebase on master and merge. |
| end | ||
|
|
||
| defmacro import_file(_) do | ||
| raise "import_file/1 expects a literal binary as its argument" |
There was a problem hiding this comment.
raise ArgumentError, message: "import_file/1 expects a literal binary as its argument" as it is strictly an argument error :D
|
@josevalim Please take another look. |
|
Wait a minute, I think we got conflicting changes in Changelog. |
Since the argument to import_file/1 has to be a literal, it's not that difficult to construct desired path by hand
It allows one to override the standard locations where .iex is searched and also makes it possible to disable .iex loading completely.
|
❤️ 💚 💙 💛 💜 |
This is the first half of implementing #1062.
In the description of .iex files I mention the
f()helper which would erase variable bindings. IEx does not have it yet, but it would be really useful as the last expression in an .iex file if the user doesn't want to keep var bindings. Or, perhaps, there is another way to scope the code in the .iex file lexically so it doesn't leak into the shell if the user doesn't want it to?The fact that it leaks by default is by design.