Recompile only necessary deps whenever config/lock change #11201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
reviewed
Aug 23, 2021
| @@ -724,7 +850,7 @@ defmodule Mix.Compilers.Elixir do | |||
| purge_old_manifest(compile_path, data) | |||
|
|
|||
| _ -> | |||
| {[], [], %{}, nil} | |||
| {[], [], %{}, nil, nil, nil} | |||
There was a problem hiding this comment.
Should we change this function to return a map?
There was a problem hiding this comment.
Yeah, a map or a record. I will add to my todo list.
ericmj
approved these changes
Aug 23, 2021
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever there is a change to the lock file or the config file, we will now only recompile the code that depends on the dependencies that changed (or that depends on any dependency that depends on the dependency that changed).
With the improvements in #11190, it means that we now only get a full recompilation when:
This is currently WIP, tests still pending.