Settle elixir_errors:parse_error/6 InputString as charlist #11345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also as a note, the resulting snippet already will always be a binary, thanks to this characters_to_binary call. Personally I would merge #11343 but I don't mind it either way |
michallepicki
commented
Oct 25, 2021
lib/elixir/src/elixir_errors.erl
Outdated
| @@ -89,15 +89,15 @@ snippet(InputString, Location, StartLine, StartColumn) -> | |||
| Lines = string:split(InputString, "\n", all), | |||
| Snippet = elixir_utils:characters_to_binary(lists:nth(Line - StartLine + 1, Lines)), | |||
There was a problem hiding this comment.
Suggested change
| Snippet = elixir_utils:characters_to_binary(lists:nth(Line - StartLine + 1, Lines)), | |
| Snippet = lists:nth(Line - StartLine + 1, Lines), |
josevalim
reviewed
Oct 25, 2021
|
💚 💙 💜 💛 ❤️ |
|
Thanks a lot, @michallepicki! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11343
Alternatively
InputStringcould be a binary and converted from charlist to binary at the one remaining call site in Code moduleOr it the
InputStringtype could be widened tochardataas I proposed originally (the code works, just spec is inconsistent with data being passed in)