Specific base typespecs #11449
Merged
Specific base typespecs #11449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each function had `keyword` as the option type, which didn't help guard against typos or mismatched options.
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Dec 5, 2021
* Use specific options for base option typespecs Each function had `keyword` as the option type, which didn't help guard against typos or mismatched options. * Fix padding use in encode/decode identity test
fuelen
reviewed
Dec 6, 2021
| @@ -397,7 +400,7 @@ defmodule Base do | |||
| {:ok, "foob"} | |||
|
|
|||
| """ | |||
| @spec decode64(binary, keyword) :: {:ok, binary} | :error | |||
| @spec decode64(binary, ignore: :whitespace, padding: boolean) :: {:ok, binary} | :error | |||
There was a problem hiding this comment.
Is it valid to use such notation to cover reversed order of arguments decode("...", padding: true, ignore: :whitespace)?
There was a problem hiding this comment.
Great point. I've opened a PR to handle that situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each
Basefunction hadkeywordas the option type, which didn't help guard against typos or mismatched options.This also includes a small fix to the
identityspec, which passed unused options in many cases and usedpad:rather thanpadding:where appropriate.