Add PartitionSupervisor #11468
Merged
Add PartitionSupervisor #11468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A supervisor with that starts multiple partitions of the same child.
Certain processes may become bottlenecks in large systems.
If those processes can have their state trivially partitioned,
in a way there is no dependency between them, then they can use
the `PartitionSupervisor` to create multiple isolated and
independent partitions.
Once the `PartitionSupervisor` starts, you can dispatch to its
children using `{:via, PartitionSupervisor, {name, key}}`, where
`name` is the name of the `PartitionSupervisor` and key is used
for routing.
ericmj
reviewed
Dec 10, 2021
josevalim
commented
Dec 10, 2021
Co-authored-by: Eric Meadows-Jönsson <eric.meadows.jonsson@gmail.com> Co-authored-by: João Ângelo <angelojr10@gmail.com>
ericmj
approved these changes
Dec 10, 2021
fertapric
reviewed
Dec 10, 2021
sasa1977
reviewed
Dec 10, 2021
|
|
||
| ## Implementation notes | ||
|
|
||
| The `PartitionSupervisor` requires a name as an atom to be given on start, |
There was a problem hiding this comment.
This is a bit limiting, though it will probably suffice for most cases. I find it a bit disappointing that I can't start this from e.g. a child of a dynamic supervisor, or any other process which is started in unknown number of copies.
There was a problem hiding this comment.
We could make it generic by using a registry and storing the ETS table there. We would need to assemble the Registry dynamically though but that's not a problem. IIRC many OTP services get started on first use. it is doable and we can do it in the future. :)
fertapric
reviewed
Dec 10, 2021
fertapric
reviewed
Dec 10, 2021
josevalim
commented
Dec 10, 2021
Co-authored-by: Fernando Tapia Rico <fertapric@gmail.com>
spyrbri
reviewed
Dec 10, 2021
josevalim
commented
Dec 10, 2021
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A supervisor with that starts multiple partitions of the same child.
Certain processes may become bottlenecks in large systems.
If those processes can have their state trivially partitioned,
in a way there is no dependency between them, then they can use
the
PartitionSupervisorto create multiple isolated andindependent partitions.
Once the
PartitionSupervisorstarts, you can dispatch to itschildren using
{:via, PartitionSupervisor, {name, key}}, wherenameis the name of thePartitionSupervisorand key is usedfor routing.