Make Registry.send work when value part is present #11742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Apr 5, 2022
| test "send works with value", %{registry: registry} do | ||
| name = {registry, "self", "value"} | ||
| Registry.register_name(name, self()) | ||
| Registry.send(name, :message) |
There was a problem hiding this comment.
Instead of send, maybe the test can use GenServer.cast? The message will be wrapped but that’s fine.
There was a problem hiding this comment.
Updated, didn't bother to create a GenServer stub, still asserts we receive the expected message.
josevalim
reviewed
Apr 5, 2022
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11740.