Add dereference_symlinks to File.cp* #12011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
reviewed
Jul 26, 2022
lib/elixir/lib/file.ex
Outdated
| @@ -861,6 +869,18 @@ defmodule File do | |||
| explicitly disallow this behaviour. If `source` is a `file` and `destination` | |||
| is a directory, `{:error, :eisdir}` will be returned. | |||
|
|
|||
| ## Options | |||
|
|
|||
| * `:on_conflict` - Invoked a file already exists in the destination. The function | |||
There was a problem hiding this comment.
Suggested change
| * `:on_conflict` - Invoked a file already exists in the destination. The function | |
| * `:on_conflict` - Invoked if file already exists in the destination. The function |
lib/elixir/lib/file.ex
Outdated
|
|
||
| * `:dereference_symlinks` - By default, this function will copy symlinks by creating | ||
| symlinks that point to the same location. This option forces symlinks to be dereferenced | ||
| and have their contents copied instead when set to true. If the dereferenced files |
There was a problem hiding this comment.
Suggested change
| and have their contents copied instead when set to true. If the dereferenced files | |
| and have their contents copied instead when set to `true`. If the dereferenced files |
v0idpwn
reviewed
Jul 26, 2022
lib/elixir/lib/file.ex
Outdated
Comment on lines
781
to
783
| An optional `on_conflict` callback is invoked if the `destination_file` already | ||
| exists. The function receives arguments for `source_file` and `destination_file`. | ||
| It should return `true` if the existing file should be overwritten, `false` if |
There was a problem hiding this comment.
Perhaps the to-be-deprecated clauses could be be mentioned (and discouraged) in the documentation until they are officially deprecated? Otherwise they get on a limbo, where they are allowed to be used but not documented, which can be confusing: "If I'm giving a function as argument instead of a list of options, why does it work?".
josevalim
commented
Jul 26, 2022
josevalim
commented
Jul 26, 2022
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11715.