Emit consistent position meta on fn capture traces

[lukaszsamson]

While this PR fixes the bug, I'm not really sure about my approach.
Is merging the capture and dot meta keywords acceptable? Or should I explicitly pass the dot meta to trace emit?
Do we want capture_meta emitted on tracer?
Is it OK that :no_parens meta gets passed when expanding macros (see comment in expansion_test.exs)

Fixes #12023

[josevalim]

Thank you!

Merging is not acceptable. We don't perform this anywhere else and this may lead to subtle behaviour (for example, propagating the hygiene information of / to other places).

I think you should just pass the RequireMeta and ImportMeta as the AST, without merging. The tests show this is a good change IMO.

Do we want capture_meta emitted on tracer?

It is up to you. If you need this information, then capture_meta is the way to go, but we should submit it only in the tracer.

[lukaszsamson]

I think you should just pass the RequireMeta and ImportMeta as the AST, without merging. The tests show this is a good change IMO.

I originally started this PR from 1.13 branch and there doing that crashed import capture expansion with

== Compilation error in file test/elixir/kernel/quote_test.exs ==
** (CompileError) test/elixir/kernel/quote_test.exs:585: undefined function length/1 (expected Kernel.QuoteTest.ImportsHygieneTest to define such a function or for it to be imported, but none are available)

on 1.14 and master this works.

It is up to you. If you need this information, then capture_meta is the way to go, but we should submit it only in the tracer.

I don't need that currently. In references provider I only trace when a symbol (fun in that case) is used and I'm not interested in how it's used.

[josevalim]

💚 💙 💜 💛 ❤️