Skip to content

Add complete list of time units on DateTime.add/3 argument error #12152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2022
Merged

Add complete list of time units on DateTime.add/3 argument error #12152

merged 2 commits into from
Sep 23, 2022

Conversation

simonprev
Copy link
Contributor

Got an argument error that I think could be more helpful:

 ** (ArgumentError) unsupported time unit. Expected :second, :millisecond, :microsecond, :nanosecond, or a positive integer, got "day"
     code: DateTime.add(DateTime.utc_now(), -1, "day")

I expected to have all the supported time unit in the error. Since the error comes from System.convert_time_unit, I simply added a conditional that raise a new error.

josevalim
josevalim reviewed Sep 23, 2022
View reviewed changes
@josevalim josevalim merged commit d587593 into elixir-lang:main Sep 23, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

josevalim pushed a commit that referenced this pull request Sep 23, 2022
@simonprev @josevalim
Add complete list of time units on DateTime.add/3 argument error (#12152
78d6b88 
)
@simonprev simonprev deleted the feature/complete-argument-error-datetime-add branch September 23, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonprev @josevalim