Add OPT 26 to other Github actions #12570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
commented
May 18, 2023
| upload_generic_version: upload_generic_version | ||
| - otp: 25 | ||
| otp_version: 25.0 | ||
| otp_version: '25.3' |
There was a problem hiding this comment.
Question: should I add upload_generic_version: upload_generic_version here too?
There was a problem hiding this comment.
No, it is always on the lowest supported version. :)
josevalim
reviewed
May 18, 2023
.github/workflows/notify.yml
Outdated
| otp-version: 25.0 | ||
| elixir-version: 1.14.0 | ||
| otp-version: '26.0' | ||
| elixir-version: '1.14.4' |
There was a problem hiding this comment.
I don't think we need to update this one because we don't build any publishing artifact.
josevalim
reviewed
May 18, 2023
josevalim
approved these changes
May 18, 2023
|
Oh, we also need to update the release workflow ! |
Co-authored-by: José Valim <jose.valim@gmail.com>
josevalim
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OTP26 to other github actions or migrates depending.