Always respect options passed to capture_log #12721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabiwara
force-pushed
the
12720-capture-log-options
branch
from
2e2f720 to
051aff2
Compare
sabiwara
changed the title
|
I think instead of storing the formatter as a logger config, we will need to store it in the ets table. Then we call the formatter for each capture in the table. |
Yes that would make much more sense indeed. Thank you 💜 |
sabiwara
force-pushed
the
12720-capture-log-options
branch
from
051aff2 to
3ce206f
Compare
sabiwara
force-pushed
the
12720-capture-log-options
branch
from
3ce206f to
33cec48
Compare
|
Re-pushed 33cec48. |
josevalim
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #12720
update_handler_config/3seems to work but I'm not sure if there is a need for a more involved fix, and if this might create issues when used concurrently with different options?