Skip to content

Clarify upgrade path for Regex.regex? (#12785) #12786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 12, 2023
Merged

Clarify upgrade path for Regex.regex? (#12785) #12786

merged 5 commits into from
Jul 12, 2023

Conversation

thbar
Copy link
Contributor

@thbar thbar commented Jul 12, 2023 •
edited
Loading

This addresses:

Pending questions:

  • Unsure if the "xyz" style is good enough (there is no such thing in the code base at first glance) - EDIT: term is perfect
  • Make sure that the resulting expression will be formatted as code in the docs
  • How to make sure this will be seen on the versions where the warning appears (< 1.15), will this require a form of backport I presume?

whatyouhide
whatyouhide approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about the term term? 🙃

thbar and others added 2 commits July 12, 2023 17:00
@thbar @whatyouhide
Improve doc
2c91f64 
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
@thbar @whatyouhide
Improve doc
660e414 
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
whatyouhide
whatyouhide reviewed Jul 12, 2023
View reviewed changes
@thbar
Copy link
Contributor Author

thbar commented Jul 12, 2023

@whatyouhide sounds perfect! Thanks for the suggestions, which I have applied.

@thbar @whatyouhide
Update lib/elixir/pages/references/compatibility-and-deprecations.md
0da437b 
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
@thbar
Copy link
Contributor Author

thbar commented Jul 12, 2023

@whatyouhide we could go further and add this, equally useful:

What do you think?

@whatyouhide
Copy link
Member

@thbar I personally don't see the reason for using match?/2 when we now have is_struct/2. 😕

@thbar
Copy link
Contributor Author

thbar commented Jul 12, 2023

@whatyouhide ok, one upgrade path is enough in that case anyway!

@josevalim josevalim merged commit 5a5947c into elixir-lang:main Jul 12, 2023
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@josevalim
Copy link
Member

Merged and backported!

josevalim pushed a commit that referenced this pull request Jul 12, 2023
@thbar @josevalim
Clarify upgrade path for Regex.regex? (#12785) (#12786)
8422af4
@thbar thbar deleted the regex-doc branch July 12, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatyouhide whatyouhide whatyouhide approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thbar @whatyouhide @josevalim