Skip to content

Conversation

jdrexler
Copy link
Contributor

Closes Issue #1285

@josevalim
Copy link
Member

Thanks @jdrexler! There are a couple fixes pending though.

In particular, Elixir convention for ! is to raise an exception. So we need to have both chmod and chmod!. Take a look at File.rm and File.rm! for an example.

Finally, the tests do not assert the group or the type or the mode of the file after calling such functions, which we must do with the help of File.stat/1.

@jdrexler
Copy link
Contributor Author

Thanks for the clarification! I will do this fixes soon (probably tomorrow) and send a new pull request.

@josevalim
Copy link
Member

Beautiful, thank you!

josevalim pushed a commit that referenced this pull request Jun 22, 2013
Added chgrp!, chown!, and chmod! to module File
@josevalim josevalim merged commit ae03e10 into elixir-lang:master Jun 22, 2013
@jdrexler jdrexler deleted the issue-1285 branch June 22, 2013 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants