Skip to content

Use in/2 in String.replace_invalid/2 guards #13093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Use in/2 in String.replace_invalid/2 guards #13093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions lib/elixir/lib/string.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1872,18 +1872,14 @@ defmodule String do
end

defguardp replace_invalid_ii_of_iii(i, ii)
when (896 <= Bitwise.bor(Bitwise.bsl(i, 6), ii) and
Bitwise.bor(Bitwise.bsl(i, 6), ii) <= 1023) or
(32 <= Bitwise.bor(Bitwise.bsl(i, 6), ii) and
Bitwise.bor(Bitwise.bsl(i, 6), ii) <= 863)
when Bitwise.bor(Bitwise.bsl(i, 6), ii) in 32..863 or
Bitwise.bor(Bitwise.bsl(i, 6), ii) in 896..1023

defguardp replace_invalid_ii_of_iv(i, ii)
when 16 <= Bitwise.bor(Bitwise.bsl(i, 6), ii) and
Bitwise.bor(Bitwise.bsl(i, 6), ii) <= 271
when Bitwise.bor(Bitwise.bsl(i, 6), ii) in 16..271

defguardp replace_invalid_iii_of_iv(i, ii, iii)
when 1024 <= Bitwise.bor(Bitwise.bor(Bitwise.bsl(i, 12), Bitwise.bsl(ii, 6)), iii) and
Bitwise.bor(Bitwise.bor(Bitwise.bsl(i, 12), Bitwise.bsl(ii, 6)), iii) <= 17407
when Bitwise.bor(Bitwise.bor(Bitwise.bsl(i, 12), Bitwise.bsl(ii, 6)), iii) in 1024..17407

defguardp replace_invalid_is_next(next) when Bitwise.bsr(next, 6) !== 0b10

Expand Down