-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Make protocol errors pretty #14003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
josevalim
merged 9 commits into
elixir-lang:main
from
davydog187:make-protocol-errors-pretty
Nov 21, 2024
Merged
Make protocol errors pretty #14003
josevalim
merged 9 commits into
elixir-lang:main
from
davydog187:make-protocol-errors-pretty
Nov 21, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common complaint I here from people is that error messages in Elixir are not pretty. Generally, this seems to be only the case when there are large structs in codebases that render in one line and are hard to read. This PR changes the behavior to pretty inspect the structs in the case that a protocol is not implemented for some value. The downside here is that the logging will no longer be in one line, but I think this is a fair tradeoff for legibility
davydog187
commented
Nov 20, 2024
josevalim
reviewed
Nov 20, 2024
josevalim
reviewed
Nov 20, 2024
Co-authored-by: José Valim <jose.valim@gmail.com>
Co-authored-by: José Valim <jose.valim@gmail.com>
sabiwara
reviewed
Nov 20, 2024
Co-authored-by: Jean Klingler <sabiwara@proton.me>
Thank you! Can you please double check CI? I assume the tests need updating too! |
Thanks @josevalim! tests have been fixed locally, and I changed the formatting to indent it a bit. Please run the CI and take a look :) |
davydog187
commented
Nov 21, 2024
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common complaint I hear from people is that error messages in Elixir are not pretty. Generally, this seems to be only the case when there are large structs in codebases that render in one line and are hard to read.
This PR changes the behavior to pretty inspect the structs in the case that a protocol is not implemented for some value.
The downside here is that the logging will no longer be in one line, but I think this is a fair tradeoff for legibility
Before
After