Inspect ill-formed structs as maps #14718
Conversation
| test "inspect" do | ||
| asc = %{__struct__: Range, first: 1, last: 3} | ||
| desc = %{__struct__: Range, first: 3, last: 1} | ||
|
|
||
| assert inspect(asc) == "1..3" | ||
| assert inspect(desc) == "3..1//-1" | ||
| end |
There was a problem hiding this comment.
These will be rendered as maps, which I think is acceptable now?
It's been a while since stepped ranges.
lib/elixir/lib/inspect.ex
Outdated
| for %{field: field} = map <- info, | ||
| field != :__exception__, | ||
| do: map | ||
| if info = Inspect.Map.valid_struct_info(struct) do |
There was a problem hiding this comment.
Actually do we still need this if it is handled upstream in Inspect.Algebra?
Perhaps I could just call module.__info__(:struct) directly, I wasn't sure.
There was a problem hiding this comment.
I went with cab02a1, let me know if that's OK.
lib/elixir/lib/inspect/algebra.ex
Outdated
|
|
||
| def to_doc_with_opts(%_{} = struct, %Inspect.Opts{inspect_fun: fun} = opts) do | ||
| if opts.structs do | ||
| if opts.structs and Inspect.Map.valid_struct?(struct) do |
There was a problem hiding this comment.
Should we move the function to this module instead?
There was a problem hiding this comment.
Indeed makes sense, I initially thought I'd need it at several places but not anymore 👍
OK! Any particular concern regarding this? |
|
Oh, sorry, we should totally backport this to v1.19 (i was thinking about backporting to v1.18, which we should not :D). |
Haha OK. I wouldn't have thought of backporting that far 😄
Done ✅ |
|
Yeah, it was my bad. Slow Saturday morning :-) |
Close #14717