Use new OTP28.1 :re.import in escaped regex AST #14720
Draft
+56
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 for #14719.
Leverages
:re.import
added in erlang/otp#9976.Here I went for
Macro.escape
rather than:elixir_expand
, because:elixir_expand
is harder to work with since we're already in AST land and the AST for a struct is hard to pattern-match on.This works since
Macro.escape
is used in~r
, and also fixes the escaping issue discussed previously. But this is violating the assumption that escape emits AST for a literal, which is probably a no-go.Will work on supporting the
:export
option separately since this is not strictly needed for this.