Skip to content

Fix inaccurate hint for disabling :test_ignore_filters #14808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2025
Merged

Fix inaccurate hint for disabling :test_ignore_filters #14808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01752ce
Fix inaccurate hint for disabling :test_ignore_filters
sabiwara Oct 3, 2025
3dffa15
Better error message on invalid :test_ignore_filters
sabiwara Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions lib/mix/lib/mix/tasks/test.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ defmodule Mix.Tasks.Test do
{potential_test_files, directly_included_test_files} = extract_files(test_files, test_pattern)

{load_files, _ignored_files, warn_files} =
classify_test_files(potential_test_files, project)
classify_test_files(shell, potential_test_files, project)

# ensure that files given as direct argument to mix test are loaded,
# even if the test_load_filters don't match
Expand Down Expand Up @@ -797,16 +797,10 @@ defmodule Mix.Tasks.Test do
end
end

defp classify_test_files(potential_test_files, project) do
defp classify_test_files(shell, potential_test_files, project) do
test_load_filters = project[:test_load_filters] || [&String.ends_with?(&1, "_test.exs")]
elixirc_paths = project[:elixirc_paths] || []

# ignore any _helper.exs files and files that are compiled (test support files)
test_ignore_filters =
[
&String.ends_with?(&1, "_helper.exs"),
fn file -> Enum.any?(elixirc_paths, &String.starts_with?(file, &1)) end
] ++ Keyword.get(project, :test_ignore_filters, [])
test_ignore_filters = get_test_ignore_filters(shell, project)

{to_load, to_ignore, to_warn} =
for file <- potential_test_files, reduce: {[], [], []} do
Expand All @@ -827,6 +821,25 @@ defmodule Mix.Tasks.Test do
{Enum.reverse(to_load), Enum.reverse(to_ignore), Enum.reverse(to_warn)}
end

defp get_test_ignore_filters(shell, project) do
elixirc_paths = project[:elixirc_paths] || []

case Keyword.get(project, :test_ignore_filters, []) do
list when is_list(list) ->
# ignore any _helper.exs files and files that are compiled (test support files)
[
&String.ends_with?(&1, "_helper.exs"),
fn file -> Enum.any?(elixirc_paths, &String.starts_with?(file, &1)) end
] ++ list

other ->
raise_with_shell(
shell,
"Invalid configuration for :test_ignore_filters, expected a list, got: #{inspect(other)}"
)
end
end

defp any_file_matches?(file, filters) do
Enum.any?(filters, fn filter ->
case filter do
Expand All @@ -851,7 +864,7 @@ defmodule Mix.Tasks.Test do
This might indicate a typo in a test file name (for example, using "foo_tests.exs" instead of "foo_test.exs").

You can adjust which files trigger this warning by configuring the `:test_ignore_filters` option in your
Mix project's configuration. To disable the warning entirely, set that option to false.
Mix project's configuration. To disable the warning entirely, set that option to [fn _ -> true end].

For more information, run `mix help test`.
""")
Expand Down