Skip to content

Conversation

ericmj
Copy link
Member

@ericmj ericmj commented Sep 16, 2013

No description provided.

@josevalim
Copy link
Member

Do we need or should we tweak an existing test to account for this scenario?

José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Lead Developer

@ericmj
Copy link
Member Author

ericmj commented Sep 16, 2013

I couldn't find an existing test or fixture that could be used to test this. I could create a fixture just for testing this but that would only test that particular project which feels fragile.

@josevalim
Copy link
Member

@ericmj we can likely change an existing fixture set. I think we could emulate this issue simply by having B depending on A and then a project dependency with [B, A]. Since B depends on A but A comes after B in the upper breadth, without this commit, it wouldn't be moved and cause a failure.

@ericmj
Copy link
Member Author

ericmj commented Sep 16, 2013

@josevalim Thanks for the tip. I amended the first commit 0c80905 with a test and confirmed that the test fails on master.

josevalim pushed a commit that referenced this pull request Sep 16, 2013
Preserve correct order when deps are overriding
@josevalim josevalim merged commit d2bfd10 into elixir-lang:master Sep 16, 2013
@ericmj ericmj deleted the mix-deps-order branch June 5, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants