Fix functions as default values in records #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
successful check_value/2 needs to return its second argument
|
(This of course also needs a test that fails now and succeeds after pulling. Left as an exercise for the merger, based on the example given above. Sorry about that.) |
josevalim
pushed a commit
that referenced
this pull request
Jan 21, 2014
Fix functions as default values in records
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
successful check_value/2 needs to return its second argument
before:
iex(1)> defrecord Baz, foo: &Dict.get/1, bar: 4711
iex(2)> IO.puts inspect Baz[]
Baz[foo: nil, bar: 4711]
:ok
iex(3)>
after:
iex(4)> defrecord Baz, foo: &Dict.get/1, bar: 4711
iex(5)> IO.puts inspect Baz[]
Baz[foo: &Dict.get/1, bar: 4711]
:ok
iex(6)>