String to char list

[alco]

No description provided.

[ericmj]

They are not backwards incompatible changes since they are additions.

[alco]

• String.to_char_list! is removed. Should I have put it in an earlier release? Wouldn't be of much use.
• String.to_char_list was never removed (per the changelog), only deprecated. In the current release it will have different behaviour which is a breaking change.

I may have missed a couple of deprecations, so maybe it would be better for you to update the changelog to reflect the actual (not wishful) situation?

[ericmj]

I take it back. You are right, they were removed and readded in the same release.

[josevalim]

I think we should remove those entries in the CHANGELOG. The previous code was previously deprecated (printing warnings) and has been removed from master for a while.

[ericmj]

String.to_char_list! is removed though. Do we not add removed functions as a backwards incompatible change if they were deprecated previously?

If something changes on master and then changes back between two releases it should not affect the changelog imo.

[josevalim]

String.to_char_list! was deprecated too: bb8f3aa#diff-22d92528e5319c6e47e28d62cbff5be7L1206

[ericmj]

@josevalim Okay, I just thought we added deprecations as backwards incompatible changes when they were finally removed. But that doesn't seem to be case.

There is nothing in the changelog about String.to_char_list! being deprecated though.