Skip to content

Fix logger watcher race condition #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2014
Merged

Fix logger watcher race condition #2712

merged 1 commit into from
Aug 23, 2014
+29 −23

Conversation

fishcakez
Copy link
Member

Previously a backend could be removed from logger and the watcher would not have exited before the Logger.remove_backend/1 call returned. This meant that a new watcher could not always be started because the child (watcher) might still exist but be about to die.

I need to investigate whether switching to a simple_one_for_one with non-temporary children that can return :ignore will cause a problem - it might.

@fishcakez
Fix logger watcher race condition
c0a0757 
Previously a backend could be removed from logger and the watcher would
not have exited before the remove_backend/1 call returned. This meant
that a new watcher could not always be started because the child
(watcher) might still exist but be about to die.
josevalim pushed a commit that referenced this pull request Aug 23, 2014
Merge pull request #2712 from fishcakez/logger_rc
6827431 
Fix logger watcher race condition
@josevalim josevalim merged commit 6827431 into elixir-lang:master Aug 23, 2014
@fishcakez fishcakez deleted the logger_rc branch April 22, 2017 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishcakez @josevalim