Skip to content

Conversation

styx
Copy link
Contributor

@styx styx commented Sep 2, 2014

Initial version, awaiting for review (:

@josevalim
Copy link
Member

Thanks! However, relative_to already uses split which normalizes the drive letter for windows (which is the only case we care about). My suggestion would then be to simply add the tests you added to the a new test named relative_to_win around here: https://github.com/elixir-lang/elixir/blob/master/lib/elixir/test/elixir/path_test.exs#L32

What do you think?

@styx
Copy link
Contributor Author

styx commented Sep 3, 2014

Yeah, you are right, I just checked the test file and found a strip_drive_letter_if_windows in a test file. This is really tricky (: I'll move the tests and remove my own wheel.

@styx
Copy link
Contributor Author

styx commented Sep 3, 2014

Originally I also was thinking about the same processing of windows paths both on Linux and windows.

Signed-off-by: Mikhail S. Pobolovets <styx.mp@gmail.com>
josevalim pushed a commit that referenced this pull request Sep 3, 2014
@josevalim josevalim merged commit 5dbd91e into elixir-lang:master Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants