Report correct location if local.hex failed #2787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -366,25 +366,34 @@ defmodule Mix.Utils do | |||
|
|
|||
| * `:shell` - Forces the use of `wget` or `curl` to fetch the file if the | |||
| given path is a URL. | |||
|
|
|||
| * `:file` - Writes the output to a file specified by given path instead | |||
There was a problem hiding this comment.
Since we are changing the return value, I agree with you, this is better as a new function. :S
|
Pushed with discussed changes. |
| if opts[:force] || overwriting?(target) do | ||
| cond do | ||
| url?(source) && opts[:shell] -> | ||
| read_shell(source, file: target) |
There was a problem hiding this comment.
Should we pass the target directly instead of making it an option?
josevalim
added a commit
that referenced
this pull request
Sep 27, 2014
Report correct location if local.hex failed
josevalim
added a commit
that referenced
this pull request
Sep 27, 2014
Report correct location if local.hex failed Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2765.