Fix command_to_module_name not converting snakecased names properly #2891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -284,7 +284,7 @@ defmodule Mix.Utils do | |||
| """ | |||
| def command_to_module_name(s) do | |||
| Regex.split(~r/\./, to_string(s)) |> | |||
| Enum.map(&first_to_upper(&1)) |> | |||
There was a problem hiding this comment.
It doesn't seem we use first_to_upper anymore. Plus module_name_to_command uses first_to_lower which we should probably fix and remove too. :)
There was a problem hiding this comment.
Ok. I'll make these changes this evening
|
@josevalim Updated and ready to go |
josevalim
added a commit
that referenced
this pull request
Nov 13, 2014
Fix command_to_module_name not converting snakecased names properly
josevalim
added a commit
that referenced
this pull request
Nov 13, 2014
Fix command_to_module_name not converting snakecased names properly Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, snake cased project names did not get converted properly into modules from
Mix.Utils.command_to_module_name, i.e.:This PR uses
camelizeto properly convert the commands to module namespaces.