Make Access syntax fail to compile for unsupported values #4076
Conversation
| unless is_atom(key) do | ||
| raise ArgumentError, | ||
| "the Access for keywords expect the key to be an atom, got: " <> inspect(key) | ||
| end |
There was a problem hiding this comment.
Should be cleaner to move this to its own clause.
There was a problem hiding this comment.
I've made it at first place but decided to keep list-related logic grouped, but have no strong feelings one way or the other. 😄
lexmag
force-pushed
the
access-error
branch
5 times, most recently
from
bec1a7b to
2f68c0a
Compare
lexmag
changed the title
| rewrite(?access, _DotMeta, 'get', Meta, [Arg, _], Env) | ||
| when ?is_literal(Arg) orelse element(1, Arg) == '{}' orelse element(1, Arg) == '<<>>' -> | ||
| elixir_errors:compile_error(Meta, ?m(Env, file), | ||
| "the Access is not available for the value: ~ts", ['Elixir.Macro':to_string(Arg)]); |
There was a problem hiding this comment.
But this place handles not only Access syntax [] but also actual Access calls.
There was a problem hiding this comment.
Or if you want, be explicit: "the Access syntax and calls to Access.get/2 are not available for..."
There was a problem hiding this comment.
It could be strange to say "Access syntax" for Access.get(1, :foo) call.
There was a problem hiding this comment.
"the Access syntax and calls to Access.get/2 are not available for the value: 1"
|
I've added just tiny comments, |
Make Access syntax fail to compile for unsupported values
Closes #4070.