New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor correction to URI.encode_query/1's doc block #4361

Merged
merged 1 commit into from Mar 6, 2016

Conversation

Projects
None yet
3 participants
@zachgarwood
Copy link
Contributor

zachgarwood commented Mar 5, 2016

Currently, the doc block states that "keys and values are URL encoded as per encode/2" when they are actually encoded using encode_www_form/1.

I made this clarification and also added an example to demonstrate that the resulting params' spaces are replaced with + instead of %20, as would be the case with encode/2.

Minor correction to URI.encode_query/1's doc block
Currently, the doc block states that "keys and values are URL encoded as
per `encode/2`" when they are actually encoded using
`encode_www_form/1`.

ericmj added a commit that referenced this pull request Mar 6, 2016

Merge pull request #4361 from zachgarwood/correction-to-URI-encode_qu…
…ery-1-doc

Minor correction to URI.encode_query/1's doc block

@ericmj ericmj merged commit f147ba7 into elixir-lang:master Mar 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ericmj

This comment has been minimized.

Copy link
Member

ericmj commented Mar 6, 2016

Thank you!

@josevalim

This comment has been minimized.

Copy link
Member

josevalim commented Mar 6, 2016

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment