Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Macro.camelize/1 for screaming snake case #5662

Merged
merged 2 commits into from Jan 18, 2017

Conversation

@adkron
Copy link
Contributor

adkron commented Jan 16, 2017

The screaming snake case was keeping its original format after being
camelized. As mentioned in issue #5627. This change allows it to behave
like the all lower snake case when camelized.

Amos King @adkron amos@binarynoggin.com

adkron added 2 commits Jan 16, 2017
The screaming snake case was keeping its original format after being
camelized. As mentioned in issue #5627. This change allows it to behave
like the all lower snake case when camelized.

Amos King @adkron <amos@binarynoggin.com>
Since we already handle moving to upcase when we camelize we can remove
a complex clause for handling upcase by utilizing the original
Macro.camelize/1.

Amos King @adkron <amos@binarynoggin.com>
@josevalim josevalim merged commit 1e1e573 into elixir-lang:master Jan 18, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@josevalim
Copy link
Member

josevalim commented Jan 18, 2017

❤️ 💚 💙 💛 💜

@adkron adkron deleted the BinaryNoggin:macro_underscore_fix branch Jan 18, 2017
AndrewDryga added a commit to AndrewDryga/elixir that referenced this pull request Jan 28, 2017
The screaming snake case was keeping its original format after being
camelized. As mentioned in issue elixir-lang#5627. This change allows it to behave
like the all lower snake case when camelized.
ckampfe added a commit to ckampfe/elixir that referenced this pull request Jul 22, 2017
The screaming snake case was keeping its original format after being
camelized. As mentioned in issue elixir-lang#5627. This change allows it to behave
like the all lower snake case when camelized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.