Fix Macro.camelize/1 for screaming snake case #5662

Merged
merged 2 commits into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@adkron
Contributor

adkron commented Jan 16, 2017

The screaming snake case was keeping its original format after being
camelized. As mentioned in issue #5627. This change allows it to behave
like the all lower snake case when camelized.

Amos King @adkron amos@binarynoggin.com

adkron added some commits Jan 16, 2017

Fix Macro.camelize/1 for screaming snake case
The screaming snake case was keeping its original format after being
camelized. As mentioned in issue #5627. This change allows it to behave
like the all lower snake case when camelized.

Amos King @adkron <amos@binarynoggin.com>
Remove dependency on previous when using Macro.camelize
Since we already handle moving to upcase when we camelize we can remove
a complex clause for handling upcase by utilizing the original
Macro.camelize/1.

Amos King @adkron <amos@binarynoggin.com>

@josevalim josevalim merged commit 1e1e573 into elixir-lang:master Jan 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@josevalim

This comment has been minimized.

Show comment
Hide comment
@josevalim

josevalim Jan 18, 2017

Member

❤️ 💚 💙 💛 💜

Member

josevalim commented Jan 18, 2017

❤️ 💚 💙 💛 💜

@adkron adkron deleted the BinaryNoggin:macro_underscore_fix branch Jan 18, 2017

AndrewDryga added a commit to AndrewDryga/elixir that referenced this pull request Jan 28, 2017

Fix Macro.camelize/1 for screaming snake case (#5662)
The screaming snake case was keeping its original format after being
camelized. As mentioned in issue #5627. This change allows it to behave
like the all lower snake case when camelized.

ckampfe added a commit to ckampfe/elixir that referenced this pull request Jul 22, 2017

Fix Macro.camelize/1 for screaming snake case (#5662)
The screaming snake case was keeping its original format after being
camelized. As mentioned in issue #5627. This change allows it to behave
like the all lower snake case when camelized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment