Skip to content

Fix Macro.camelize/1 for screaming snake case #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2017

Conversation

adkron
Copy link
Contributor

@adkron adkron commented Jan 16, 2017

The screaming snake case was keeping its original format after being
camelized. As mentioned in issue #5627. This change allows it to behave
like the all lower snake case when camelized.

Amos King @adkron amos@binarynoggin.com

The screaming snake case was keeping its original format after being
camelized. As mentioned in issue elixir-lang#5627. This change allows it to behave
like the all lower snake case when camelized.

Amos King @adkron <amos@binarynoggin.com>
Since we already handle moving to upcase when we camelize we can remove
a complex clause for handling upcase by utilizing the original
Macro.camelize/1.

Amos King @adkron <amos@binarynoggin.com>
@josevalim josevalim merged commit 1e1e573 into elixir-lang:master Jan 18, 2017
@josevalim
Copy link
Member

❤️ 💚 💙 💛 💜

@adkron adkron deleted the macro_underscore_fix branch January 18, 2017 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants